Previous

199869 Revisions

Next

r41670 Monday 9th November, 2015 at 12:50:57 UTC by Ryan Holtz
- Fix PVS-Studio warning V562, "It's odd to compare a bool type value with  a value of 0/1" [MooglyGuy]

[src/devices/cpu/dsp32]	dsp32.cpp
[src/devices/cpu/i8085]	i8085.cpp i8085.h
[src/devices/cpu/nec]	necinstr.inc
[src/devices/sound]	tms5110.cpp tms5220.cpp
[src/lib/formats]	upd765_dsk.cpp
[src/mame/drivers]	rabbit.cpp vboy.cpp
[src/mame/machine]	namcos2.cpp

trunk/src/devices/cpu/dsp32/dsp32.cpp

r250181	r250182
344	344	{
345	345	case STATE_GENFLAGS:
346	346	// no actual flags register, so just make something up
347		m_iotemp =  ((zFLAG != 0) << 0) |
348		((nFLAG != 0) << 1) |
349		((cFLAG != 0) << 2) |
350		((vFLAG != 0) << 3) |
351		((ZFLAG != 0) << 4) |
352		((NFLAG != 0) << 5) |
353		((UFLAG != 0) << 6) |
354		((VFLAG != 0) << 7);
	347	m_iotemp =  (zFLAG ? 0x01 : 0) |
	348	(nFLAG ? 0x02 : 0) |
	349	(cFLAG ? 0x04 : 0) |
	350	(vFLAG ? 0x08 : 0) |
	351	(ZFLAG ? 0x10 : 0) |
	352	(NFLAG ? 0x20 : 0) |
	353	(UFLAG ? 0x40 : 0) |
	354	(VFLAG ? 0x80 : 0);
355	355	break;
356	356
357	357	case DSP32_PCR:

trunk/src/devices/cpu/i8085/i8085.cpp

r250181	r250182
916	916	m_trap_pending = 0;
917	917	m_trap_im_copy = 0;
918	918	m_sod_state = 0;
919		m_ietemp = 0;
	919	m_ietemp = false;
920	920
921	921	init_tables();
922	922
r250181	r250182
1005	1005	{
1006	1006	case I8085_SID:
1007	1007	if (m_ietemp)
1008		m_IM |= IM_SID;
	1008	{
	1009	m_IM |= IM_SID;
	1010	}
1009	1011	else
	1012	{
1010	1013	m_IM &= ~IM_SID;
	1014	}
1011	1015	break;
1012	1016
1013	1017	case I8085_INTE:
1014	1018	if (m_ietemp)
	1019	{
1015	1020	m_IM |= IM_IE;
	1021	}
1016	1022	else
	1023	{
1017	1024	m_IM &= ~IM_IE;
	1025	}
1018	1026	break;
1019	1027
1020	1028	default:
r250181	r250182
1028	1036	switch (entry.index())
1029	1037	{
1030	1038	case I8085_SID:
1031		{
1032		int sid = m_in_sid_func();
1033
1034		m_ietemp = ((m_IM & IM_SID) != 0);
1035		m_ietemp = (sid != 0);
1036		}
	1039	m_ietemp = ((m_IM & IM_SID) != 0) && m_in_sid_func() != 0;
1037	1040	break;
1038	1041
1039	1042	case I8085_INTE:

trunk/src/devices/cpu/i8085/i8085.h

r250181	r250182
116	116	UINT8               m_trap_im_copy;   /* copy of IM register when TRAP was taken */
117	117	UINT8               m_sod_state;      /* state of the SOD line */
118	118
119		UINT8               m_ietemp;         /* import/export temp space */
	119	bool                m_ietemp;         /* import/export temp space */
120	120
121	121	address_space *m_program;
122	122	direct_read_data *m_direct;

trunk/src/devices/cpu/nec/necinstr.inc

r250181	r250182
571	571	case 0x6f:  CLK(2); if (c) do { i_outsw(); c--; } while (c>0); Wreg(CW)=c; break;
572	572	case 0xa4:  CLK(2); if (c) do { i_movsb(); c--; } while (c>0); Wreg(CW)=c; break;
573	573	case 0xa5:  CLK(2); if (c) do { i_movsw(); c--; } while (c>0); Wreg(CW)=c; break;
574		case 0xa6:  CLK(2); if (c) do { i_cmpsb(); c--; } while (c>0 && ZF==0);    Wreg(CW)=c; break;
575		case 0xa7:  CLK(2); if (c) do { i_cmpsw(); c--; } while (c>0 && ZF==0);    Wreg(CW)=c; break;
	574	case 0xa6:  CLK(2); if (c) do { i_cmpsb(); c--; } while (c>0 && !ZF);    Wreg(CW)=c; break;
	575	case 0xa7:  CLK(2); if (c) do { i_cmpsw(); c--; } while (c>0 && !ZF);    Wreg(CW)=c; break;
576	576	case 0xaa:  CLK(2); if (c) do { i_stosb(); c--; } while (c>0); Wreg(CW)=c; break;
577	577	case 0xab:  CLK(2); if (c) do { i_stosw(); c--; } while (c>0); Wreg(CW)=c; break;
578	578	case 0xac:  CLK(2); if (c) do { i_lodsb(); c--; } while (c>0); Wreg(CW)=c; break;
579	579	case 0xad:  CLK(2); if (c) do { i_lodsw(); c--; } while (c>0); Wreg(CW)=c; break;
580		case 0xae:  CLK(2); if (c) do { i_scasb(); c--; } while (c>0 && ZF==0);    Wreg(CW)=c; break;
581		case 0xaf:  CLK(2); if (c) do { i_scasw(); c--; } while (c>0 && ZF==0);    Wreg(CW)=c; break;
	580	case 0xae:  CLK(2); if (c) do { i_scasb(); c--; } while (c>0 && !ZF);    Wreg(CW)=c; break;
	581	case 0xaf:  CLK(2); if (c) do { i_scasw(); c--; } while (c>0 && !ZF);    Wreg(CW)=c; break;
582	582	default:    logerror("%06x: REPNE invalid\n",PC());    (this->*s_nec_instruction[next])();
583	583	}
584	584	m_seg_prefix=FALSE;
r250181	r250182
598	598	case 0x6f:  CLK(2); if (c) do { i_outsw(); c--; } while (c>0); Wreg(CW)=c; break;
599	599	case 0xa4:  CLK(2); if (c) do { i_movsb(); c--; } while (c>0); Wreg(CW)=c; break;
600	600	case 0xa5:  CLK(2); if (c) do { i_movsw(); c--; } while (c>0); Wreg(CW)=c; break;
601		case 0xa6:  CLK(2); if (c) do { i_cmpsb(); c--; } while (c>0 && ZF==1);    Wreg(CW)=c; break;
602		case 0xa7:  CLK(2); if (c) do { i_cmpsw(); c--; } while (c>0 && ZF==1);    Wreg(CW)=c; break;
	601	case 0xa6:  CLK(2); if (c) do { i_cmpsb(); c--; } while (c>0 && ZF);    Wreg(CW)=c; break;
	602	case 0xa7:  CLK(2); if (c) do { i_cmpsw(); c--; } while (c>0 && ZF);    Wreg(CW)=c; break;
603	603	case 0xaa:  CLK(2); if (c) do { i_stosb(); c--; } while (c>0); Wreg(CW)=c; break;
604	604	case 0xab:  CLK(2); if (c) do { i_stosw(); c--; } while (c>0); Wreg(CW)=c; break;
605	605	case 0xac:  CLK(2); if (c) do { i_lodsb(); c--; } while (c>0); Wreg(CW)=c; break;
606	606	case 0xad:  CLK(2); if (c) do { i_lodsw(); c--; } while (c>0); Wreg(CW)=c; break;
607		case 0xae:  CLK(2); if (c) do { i_scasb(); c--; } while (c>0 && ZF==1);    Wreg(CW)=c; break;
608		case 0xaf:  CLK(2); if (c) do { i_scasw(); c--; } while (c>0 && ZF==1);    Wreg(CW)=c; break;
	607	case 0xae:  CLK(2); if (c) do { i_scasb(); c--; } while (c>0 && ZF);    Wreg(CW)=c; break;
	608	case 0xaf:  CLK(2); if (c) do { i_scasw(); c--; } while (c>0 && ZF);    Wreg(CW)=c; break;
609	609	default:    logerror("%06x: REPE invalid\n",PC()); (this->*s_nec_instruction[next])();
610	610	}
611	611	m_seg_prefix=FALSE;

trunk/src/devices/sound/tms5110.cpp

r250181	r250182
393	393	* Old frame was unvoiced, new is voiced
394	394	* Old frame was unvoiced, new frame is silence/zero energy (non-existent on tms51xx rev D and F (present and working on tms52xx, present but buggy on tms51xx rev A and B))
395	395	*/
396		if ( ((OLD_FRAME_UNVOICED_FLAG == 0) && (NEW_FRAME_UNVOICED_FLAG == 1))
397		|| ((OLD_FRAME_UNVOICED_FLAG == 1) && (NEW_FRAME_UNVOICED_FLAG == 0))
398		|| ((OLD_FRAME_SILENCE_FLAG == 1) && (NEW_FRAME_SILENCE_FLAG == 0)) )
	396	if ( ((OLD_FRAME_UNVOICED_FLAG == 0) && NEW_FRAME_UNVOICED_FLAG)
	397	|| ((OLD_FRAME_UNVOICED_FLAG == 1) && !NEW_FRAME_UNVOICED_FLAG)
	398	|| ((OLD_FRAME_SILENCE_FLAG == 1) && !NEW_FRAME_SILENCE_FLAG) )
399	399	//|| ((m_inhibit == 1) && (OLD_FRAME_UNVOICED_FLAG == 1) && (NEW_FRAME_SILENCE_FLAG == 1)) ) //TMS51xx INTERP BUG1
400	400	//|| ((OLD_FRAME_UNVOICED_FLAG == 1) && (NEW_FRAME_SILENCE_FLAG == 1)) )
401	401	m_inhibit = 1;

trunk/src/devices/sound/tms5220.cpp

r250181	r250182
788	788	* Old frame was unvoiced, new is voiced
789	789	* Old frame was unvoiced, new frame is silence/zero energy (non-existent on tms51xx rev D and F (present and working on tms52xx, present but buggy on tms51xx rev A and B))
790	790	*/
791		if ( ((OLD_FRAME_UNVOICED_FLAG == 0) && (NEW_FRAME_UNVOICED_FLAG == 1))
792		|| ((OLD_FRAME_UNVOICED_FLAG == 1) && (NEW_FRAME_UNVOICED_FLAG == 0))
793		|| ((OLD_FRAME_SILENCE_FLAG == 1) && (NEW_FRAME_SILENCE_FLAG == 0))
	791	if ( ((OLD_FRAME_UNVOICED_FLAG == 0) && NEW_FRAME_UNVOICED_FLAG)
	792	|| ((OLD_FRAME_UNVOICED_FLAG == 1) && !NEW_FRAME_UNVOICED_FLAG)
	793	|| ((OLD_FRAME_SILENCE_FLAG == 1) && !NEW_FRAME_SILENCE_FLAG)
794	794	//|| ((m_inhibit == 1) && (OLD_FRAME_UNVOICED_FLAG == 1) && (NEW_FRAME_SILENCE_FLAG == 1)) ) //TMS51xx INTERP BUG1
795		|| ((OLD_FRAME_UNVOICED_FLAG == 1) && (NEW_FRAME_SILENCE_FLAG == 1)) )
	795	|| ((OLD_FRAME_UNVOICED_FLAG == 1) && NEW_FRAME_SILENCE_FLAG) )
796	796	m_inhibit = 1;
797	797	else // normal frame, normal interpolation
798	798	m_inhibit = 0;

trunk/src/lib/formats/upd765_dsk.cpp

r250181	r250182
304	304	// Handling enough tracks is better than not
305	305	if(cn.track_count >= tracks && cc.track_count < tracks)
306	306	goto change;
307		else if(cn.track_count >= tracks && cc.track_count < tracks)
	307	else if(cc.track_count >= tracks && cn.track_count < tracks)
308	308	goto dont_change;
309	309
310	310	// Both are on the same side of the track count, so closest is best

trunk/src/mame/drivers/rabbit.cpp

r250181	r250182
314	314
315	315	xflip = (source[0]&0x00008000)>>15;
316	316	yflip = (source[0]&0x00004000)>>14;
317		colr = (source[1]&0x0ff00000)>>15;
318	317
319
320	318	tileno = (source[1]&0x0001ffff);
321	319	colr =   (source[1]&0x0ff00000)>>20;
322	320

trunk/src/mame/drivers/vboy.cpp

r250181	r250182
627	627	//              attotime new_time = machine().time();
628	628
629	629	//              if((new_time - m_input_latch_time) < m_maincpu->cycles_to_attotime(640))
630		value |= machine().rand() & 2;
	630	//                  value |= machine().rand() & 2;
631	631
632	632	value = m_vboy_regs.kcr | 0x4c;
633	633	}

trunk/src/mame/machine/namcos2.cpp

r250181	r250182
674	674	INTERRUPT_GEN_MEMBER(namcos2_shared_state::namcos2_68k_gpu_vblank)
675	675	{
676	676	/* only used by namcos21 */
677		int scanline = get_posirq_scanline();
678		scanline = 0x50+0x89; /* HACK for Winning Run */
	677	//int scanline = get_posirq_scanline();
	678	INT32 scanline = 0x50+0x89; /* HACK for Winning Run */
679	679
680	680	//printf( "namcos2_68k_gpu_vblank(%d)\n",m_68k_gpu_C148[NAMCOS2_C148_POSIRQ] );
681	681	adjust_posirq_timer(scanline);

https://github.com/mamedev/mame/commit/bf5cee9b9ed3eb4123b0034c4fd1b9ccbda4c2ac

Previous

199869 Revisions

Next

---

© 1997-2024 The MAME Team