MAME SVN History

199869 Revisions

r188782 Tuesday 2nd August, 2022 at 16:27:49 UTC by Vasantha Crabb
ui/icorender.cpp: Revert initialisations that can hide real bugs. MSVC isn't smart enough to detect that these can only be used after being assigned while clang and GCC can work it out fine. Initialising them to zero at declaration has the potential to mask real bugs if some code path tries to use them without assigning them. Code flow analysis (e.g. Coverity) or memory analysers (e.g. valgrind or Purify) won't pick up on the buggy path because the variable will technically be initialised. MSVC is problematic when it comes to warnings about uninitialised variables in general. Unfortunately MSVC has no option to selectively treat warnings as errors, unlike clang/GCC which have -Wno-error= which we use extensively. Until Microsoft addresses these issues, you'll have to use NOWERROR=1 when building with MSVC. Also, some cleanup.

r188782 Tuesday 2nd August, 2022 at 16:27:49 UTC by Vasantha Crabb

ui/icorender.cpp: Revert initialisations that can hide real bugs.

MSVC isn't smart enough to detect that these can only be used after
being assigned while clang and GCC can work it out fine. Initialising
them to zero at declaration has the potential to mask real bugs if some
code path tries to use them without assigning them. Code flow analysis
(e.g. Coverity) or memory analysers (e.g. valgrind or Purify) won't pick
up on the buggy path because the variable will technically be
initialised.

MSVC is problematic when it comes to warnings about uninitialised
variables in general. Unfortunately MSVC has no option to selectively
treat warnings as errors, unlike clang/GCC which have -Wno-error= which
we use extensively. Until Microsoft addresses these issues, you'll have
to use NOWERROR=1 when building with MSVC.

Also, some cleanup.

[/branches/barcrest/src/emu/debug]	debugcmd.cpp
[/branches/barcrest/src/frontend/mame/ui]	icorender.cpp
[/branches/barcrest/src/osd/modules/debugger]	debuggdbstub.cpp

https://github.com/mamedev/mame/commit/7cc3481d8ff8893fa8a5ccef4cffd97d73403bc0

199869 Revisions